Support new PHP 8.3 syntaxes

[jrfnl]

PHP 8.3 includes the following new syntaxes for which it should be verified if the Tokenizer needs updates and/or whether any sniffs need updates:

To Do

• Dynamic class constant fetch - C::{$name}
  • Tokenizer changes needed ?
  • Sniff updates needed ?

Done

• Readonly anonymous classes - new readonly class {};
  • Tokenizer changes needed - PR PHP 8.3 | Tokenizer/PHP: add support for readonly anonymous classes #309
  • Updates needed to utility functions - getClassProperties()
  • Sniff updates needed - PRs PHP 8.3 | Add tests with readonly anonymous classes to various sniffs #323 + PHP 8.3 | PSR12/ClassInstantiation: allow for readonly anonymous classes #324
• Typed class constants
  • Tokenizer changes needed - PR PHP 8.3 | Tokenizer/PHP: add support for typed OO constants #321
    Blocked until PR PHP 8.2 | Tokenizer, File, sniffs: account for new true type squizlabs/PHP_CodeSniffer#3662 / PHP 8.2 | Tokenizer, File, sniffs: account for new true type #49 has been merged.
  • Sniff updates needed - PRs PHP 8.3 | Generic/LowerCaseConstant: add support for typed constants #330 + PHP 8.3 | Generic/LowerCaseType: add support for typed constants #331 + PHP 8.3 | Generic/UpperCaseConstantName: add support for typed constants #332
    Also see PHP 8.3 - Typed class constants support squizlabs/PHP_CodeSniffer#3927
    Blocked until PR Tokenizer/PHP: bug fix for static typed properties with union/intersection types squizlabs/PHP_CodeSniffer#3867 / Tokenizer/PHP: bug fix for static typed properties with union/intersection types #78 has been merged.

[leitommi]

Is there any news on this? Dependencies seem to be released.

[jrfnl]

@leitommi What dependencies are you talking about ?

[leitommi]

I mean these PR-s are merged that were marked as "Blocked until":
#49
#78

I am mostly interested in typed class constants that were introduced in php 8.3.

Currently following code:

class A
{
  const int $MY_VAL;
}

produces following error, with phpcs 3.8.0:

phpcs: Generic.NamingConventions.UpperCaseConstantName.ClassConstantNotUpperCase: Class constants must be uppercase; expected INT but found int

[jrfnl]

For whoever cares - PR #309 is open adding tokenizer support for readonly anonymous classes and PR #321 adding tokenizer support for typed class constants.

Once those two are merged, support can be added to individual sniffs (and yes, the commits for this are ready and waiting).

[jrfnl]

The following three PRs have been opened to add support for PHP 8.3 typed class constants to various sniffs:

• PHP 8.3 | Generic/LowerCaseConstant: add support for typed constants #330
• PHP 8.3 | Generic/LowerCaseType: add support for typed constants #331
• PHP 8.3 | Generic/UpperCaseConstantName: add support for typed constants #332

Testing of these PRs would be appreciated.

[FabianKoestring]

The following three PRs have been opened to add support for PHP 8.3 typed class constants to various sniffs:

• PHP 8.3 | Generic/LowerCaseConstant: add support for typed constants #330
• PHP 8.3 | Generic/LowerCaseType: add support for typed constants #331
• PHP 8.3 | Generic/UpperCaseConstantName: add support for typed constants #332

Testing of these PRs would be appreciated.

Everything works as expected for me.✌️👍 When can we expect a release?

[KeldorDE]

The following three PRs have been opened to add support for PHP 8.3 typed class constants to various sniffs:

• PHP 8.3 | Generic/LowerCaseConstant: add support for typed constants #330
• PHP 8.3 | Generic/LowerCaseType: add support for typed constants #331
• PHP 8.3 | Generic/UpperCaseConstantName: add support for typed constants #332

Testing of these PRs would be appreciated.

I can also confirm that everything is working correctly. 👍

[jrfnl]

@FabianKoestring @KeldorDE Thank you both for testing. Unless something unexpected happens, I'm hoping to release the 3.9.0 version towards the end of next week.

[jrfnl]

Version 3.9.0 has been tagged & released.

I'm leaving this issue open for now as the last bullet still needs to be investigated, though I don't really expect any issues with that syntax, but I'd rather be sure.