Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PHPCS invocation fails on Windows 10 if installed globally #50

Closed
jonathanjfshaw opened this issue Jun 1, 2018 · 9 comments
Closed
Assignees

Comments

@jonathanjfshaw
Copy link

jonathanjfshaw commented Jun 1, 2018

Problem/Motivation

Running composer update in a project fails on Windows 10 when this plugin is installed globally.

Error

  [Symfony\Component\Process\Exception\ProcessFailedException]
  The command ""C:\users\jonathan\drupal\behatdrupal/vendor/bin\phpcs" "--config-show" "installed_paths"" failed.
  Exit Code: 1(General error)
  Working directory: C:\users\jonathan\drupal\behatdrupal
  Output:
  ================
  Error Output:
  =
===============
  '"C:\users\jonathan\drupal\behatdrupal/vendor/bin\phpcs"' is not recognized as an internal or external command,
  operable program or batch file.

@frenck
Copy link
Contributor

frenck commented Oct 25, 2018

Not sure why this is handled differently on Windows.
I personally do not have access to Windows machines, so this needs to be solved/triaged by external contributors.

@jrfnl
Copy link
Member

jrfnl commented Jan 21, 2019

@jonathanjfshaw I haven't tested with a global install, but I wouldn't be surprised if PR #80 would fix this issue as well as it changes the command used.

Would you be able to test PR #80 with your setup ?

@jonathanjfshaw
Copy link
Author

Sorry, no, I don't have a suitable working composer setup

@Potherca
Copy link
Member

Potherca commented May 7, 2019

I'll have a look at this soonish, together with #79 and #80.

@Potherca Potherca self-assigned this May 7, 2019
@Potherca
Copy link
Member

Version v0.6.0 has just been released. Besides several fixes, this version also adds improved debug/verbose output.

@jonathanjfshaw Could you try to reproduce the issue you reported with v0.6.0 and let us know if it still happens? If so, please run the plugin in verbose mode and paste the output of the run here (that should make it possible for us to re-produce the issue ourselves).

@jrfnl
Copy link
Member

jrfnl commented May 5, 2020

@jonathanjfshaw Any feedback ? I would love to know if this is still an issue or if this can be closed.

@jonathanjfshaw
Copy link
Author

Sorry, I'm no longer using composer on Windows 10 so can't retest.

@Potherca
Copy link
Member

Potherca commented May 6, 2020

As luck would have it, I now have access to a Windows 10 machine (we've had to buy a family computer to keep up with all the video meetings the children have for school).

My current timetable would allow me to take a look at this the coming weekend. I'll post my findings as soon as I've run throught things. 👍

@Potherca
Copy link
Member

I've finally gotten round to running this on a Windows machine.

Both powershell and regular shell give me no trouble with a global install present.

Closing this as it can not be reproduced.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants