Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Suggest using development branch in README.md #1312

Open
8ctopus opened this issue Feb 1, 2022 · 6 comments
Open

Suggest using development branch in README.md #1312

8ctopus opened this issue Feb 1, 2022 · 6 comments

Comments

@8ctopus
Copy link

8ctopus commented Feb 1, 2022

PHPCompatibility 9.3.5 was released on December 27, 2019 and PHP 8.0.0 was released on November 26, 2020.

As a consequence using PHPCompatibility 9.3.5 has lots of issues with PHP 8 code, so it would seem wise to suggest to use the development branch of PHPCompatibility in the README.

I can prepare a pull request if wanted.

@jlstrecker
Copy link

Good point — it took me a while to figure out why PHPCompatibility 9.3.5 wasn't reporting any errors.

I had used "Installation via a git check-out to an arbitrary directory (method 2)". I then tried the develop branch in place of the 9.3.5 release, but ran into this error.

When I instead used "Installation in a Composer project (method 1)", things worked smoothly.

Perhaps remove method 2 from the instructions? It could be added back once it's supported again (presumably with the 10.0.0 release).

@jrfnl
Copy link
Member

jrfnl commented Mar 31, 2022

I'm hoping to get PHPCompatibility 10 released within the next three months.

Once that has been released, option 2 of the install methods will no longer be supported.

@8ctopus
Copy link
Author

8ctopus commented Apr 1, 2022

Just to make it clearer for others reading this issue, the way to install the development branch is:

composer require --dev phpcompatibility/php-compatibility:dev-develop

@Jumoke
Copy link

Jumoke commented Apr 20, 2022

Just to make it clearer for others reading this issue, the way to install the development branch is:

composer require --dev phpcompatibility/php-compatibility:dev-develop

Thank you!

@voku
Copy link

voku commented Jun 13, 2022

Just to make it clearer for others reading this issue, the way to install the development branch is:

composer require --dev phpcompatibility/php-compatibility:dev-develop

Thanks for the information. 👍

@theMikeD
Copy link

theMikeD commented Sep 5, 2022

Just wondering when we can expect v10? I have a few projects with VIP and they suggest using this tool, but their solution to getting 10ish working as 9ish is a hacky kludge to get 10 acting as 9.99.99 and it's messing up every other composer package.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

6 participants