Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update terminology #1472

Closed
wants to merge 2 commits into from
Closed

Update terminology #1472

wants to merge 2 commits into from

Conversation

hugovk
Copy link

@hugovk hugovk commented Jan 24, 2023

Fixes #1404.

Rename "blacklist" to "blocklist"

Except for opcache.blacklist_filename which is a PHP config: https://www.php.net/manual/en/opcache.configuration.php#ini.opcache.blacklist-filename

There was a PR (php/php-src#5685) to rename it to opcache.exclude_list_filename but they couldn't reach consensus.

Rename "whitelist" to "allowlist"

Except for phpunit.xml.dist which is PHPUnit config.

However, when only needing PHPUnit 9.3 the following change can be made (re: sebastianbergmann/phpunit#4288):

diff --git a/phpunit.xml.dist b/phpunit.xml.dist
index 5439d0d..ee11909 100644
--- a/phpunit.xml.dist
+++ b/phpunit.xml.dist
@@ -22,12 +22,12 @@
     </testsuites>
 
     <filter>
-        <whitelist addUncoveredFilesFromWhitelist="true" processUncoveredFilesFromWhitelist="false">
+        <coverage includeUncoveredFiles="true" processUncoveredFiles="false">
             <file>./PHPCompatibility/Sniff.php</file>
             <file>./PHPCompatibility/AbstractInitialValueSniff.php</file>
             <directory>./PHPCompatibility/Sniffs/</directory>
             <directory>./PHPCompatibility/Helpers/</directory>
-        </whitelist>
+        </coverage>
     </filter>
 
     <logging>

@hugovk hugovk mentioned this pull request Jan 24, 2023
Open
@jrfnl jrfnl added this to the 10.0.0 milestone Mar 28, 2023
@hugovk hugovk closed this Oct 5, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wimg wimg wimg left review comments

Assignees
No one assigned
Labels
chores/QA
Projects
None yet
Milestone
10.0.0
Development

Successfully merging this pull request may close these issues.

Review codebase for use of whitelist/blacklist terminology
3 participants
@hugovk @wimg @jrfnl