Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

don't unregister callbacks automatically #24

Open
deian opened this issue Jul 5, 2020 · 0 comments
Open

don't unregister callbacks automatically #24

deian opened this issue Jul 5, 2020 · 0 comments

Comments

@deian
Copy link
Member

deian commented Jul 5, 2020

In prio, we ran into a really awkward thing to debug:

tainted_prio<PrioNSSCtx*> nss = sandbox.malloc_in_sandbox<PrioNSSCtx>()
...
nss->NSS_IsInitialized = sandbox.register_callback(t_NSS_IsInitialized);

eneded up getting unregister at the end of the function call.

We probably want to just manually do the unregistering and have a separate type for automatically unregistering callbacks.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@deian