skipValidate

PabloSzx · Nov 6, 2021 · afd2edb · afd2edb
1 parent 0ecbd1c
commit afd2edb
Show file tree

Hide file tree

Showing 4 changed files with 22 additions and 3 deletions.
diff --git a/.changeset/brave-mugs-shake.md b/.changeset/brave-mugs-shake.md
@@ -0,0 +1,6 @@
+---
+'bob-esbuild': patch
+'bob-esbuild-cli': patch
+---
+
+add skipValidate option
diff --git a/packages/bob-cli/src/commands/build.ts b/packages/bob-cli/src/commands/build.ts
@@ -11,7 +11,8 @@ export const BuildCommand = new Command('build')
   .option('--skipTsc', 'Skip TSC build')
   .option('--onlyCJS', 'Only build for CJS')
   .option('--onlyESM', 'Only build for ESM')
-  .action(async ({ cwd, inputFiles, bundle, clean, onlyCJS, onlyESM, skipTsc }) => {
+  .option('--skipValidate', 'Skip package.json validation')
+  .action(async ({ cwd, inputFiles, bundle, clean, onlyCJS, onlyESM, skipTsc, skipValidate }) => {
     await startBuild({
       rollup: {
         cwd,
@@ -20,6 +21,7 @@ export const BuildCommand = new Command('build')
         clean,
         onlyCJS,
         onlyESM,
+        skipValidate,
       },
       tsc: skipTsc ? false : {},
     });

diff --git a/packages/bob/src/config/packageJson.ts b/packages/bob/src/config/packageJson.ts
@@ -161,6 +161,7 @@ export interface GeneratePackageJsonOptions {
   packageJson: PackageJSON;
   distDir: string;
   cwd?: string;
+  skipValidate?: boolean;
 }
 
 export const generatePackageJson = (options: GeneratePackageJsonOptions, config: ResolvedBobConfig): Plugin | null => {
@@ -193,7 +194,7 @@ export const generatePackageJson = (options: GeneratePackageJsonOptions, config:
   return {
     name: 'GeneratePackageJson',
     async buildStart() {
-      if (!manualRewrite) validatePackageJson(options.packageJson, options.distDir);
+      if (!manualRewrite && !options.skipValidate) validatePackageJson(options.packageJson, options.distDir);
 
       this[GenPackageJson] = Promise.allSettled([
         writePackageJson(manualRewrite ? { ...options, packageJson: await manualRewrite(options.packageJson) } : options),

diff --git a/packages/bob/src/config/rollup.ts b/packages/bob/src/config/rollup.ts
@@ -44,6 +44,13 @@ export interface ConfigOptions {
    * @default false
    */
   onlyESM?: boolean;
+
+  /**
+   * Skip package.json validate
+   *
+   * @default false
+   */
+  skipValidate?: boolean;
 }
 
 export async function getRollupConfig(optionsArg: ConfigOptions = {}) {
@@ -114,7 +121,10 @@ export async function getRollupConfig(optionsArg: ConfigOptions = {}) {
 
   if (buildConfig.copy?.length) debug(`Copying ${buildConfig.copy.join(' | ')} to ${absoluteDistDir}`);
 
-  const genPackageJson = generatePackageJson({ packageJson: buildConfig.pkg, distDir, cwd }, globalOptions);
+  const genPackageJson = generatePackageJson(
+    { packageJson: buildConfig.pkg, distDir, cwd, skipValidate: options.skipValidate },
+    globalOptions
+  );
 
   const plugins: Plugin[] = [
     externals({