Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Idea/Add] get recommended Java Version from the api/v2 #77

Open
LuckCrafter opened this issue Nov 30, 2021 · 8 comments
Open

[Idea/Add] get recommended Java Version from the api/v2 #77

LuckCrafter opened this issue Nov 30, 2021 · 8 comments
Labels
type: enhancement New feature or request

Comments

@LuckCrafter
Copy link

I'll like to see a feature to get the recommended Java version for PaperMC (something like in the docs)

@electronicboy
Copy link
Member

recommended java version just seems completely irrelevant to the distribution system

@MiniDigger
Copy link
Member

I agree with cat, but I also see the other side, the api is our main communication channel to hosts, such a feature could greatly reduce the work they have to do to deploy stuff.
maybe we can add a tagging system so we can add metadata like this to version groups?

@electronicboy
Copy link
Member

My issue is, what constitutes as recommended? Tagging the build version is trivial, but, the notation of recommendations is somewhat iffy as we always just recommend the latest version that we know works for X a release, and am not sure that's something we should particularly be tryna maintain here

@MiniDigger
Copy link
Member

we already maintain it on the docs, as OP said, so idk,. what do others think?

@Machine-Maker
Copy link
Member

Why not minimum java version instead of recommended?

@e-im
Copy link

e-im commented Dec 1, 2021

Minimum you can just get via the class file version, recommended (especially back on 1.16 and below, where recommended ≠ minimum) was harder and just involved hard coding a table. Also see PaperMC/Paper#5630 for another possible approach/more rational.

@electronicboy
Copy link
Member

We maintain it on the docs in a place which isn't updating the metadata of several dozen builds at once? Unless you mean per release in which kills the granularity and creates some complexities when java issues are fixed or the max supported ver is bumped, etc
I just feel that a recommended version is far too nuanced for something which others will push onto others less fortunate

@MiniDigger
Copy link
Member

I would have defined it on the version group

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type: enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

6 participants