Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

"smarter" binary search #389

Closed
electronicboy opened this issue May 12, 2024 · 0 comments · Fixed by #402
Closed

"smarter" binary search #389

electronicboy opened this issue May 12, 2024 · 0 comments · Fixed by #402

Comments

@electronicboy
Copy link
Member

electronicboy commented May 12, 2024

A common trap that people fall into with a binary search is removing dependencies of other plugins, either data or functionality wise, it would probably be an idea to make a note of this sort of caveat;

Common examples would be Libraries like Vault (and providers for vault, i.e. perm plugins, eco, etc)/ProtocolLib, not having these installs would generally disable plugins or subsets of their functionality which could be problematic, causing these libraries to become the "blame", even if they're not actually the case of it

Permissions (or other plugins that serve to provide data for other plugins, etc) are also a common trap, because not having a perm plugin installed might be restricting functionality of a plugin because you don't have the admin permissions, this can create some proverbial fun, i.e. issues that only affect standard players and not admins due to bypass perms would not show up if you're testing with a user with perms, but, also, the inverse is true, issues that only affect features that people with perms have access/are subjected to

I think at the very least a disclaimer should be noted regarding this, ideally we'd have a means of producing a graph picture so that people can be smarter about how they install their plugins back during a binary search (i.e. start off at the edge of the graph in which stuff depends on)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant