-
-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Refactors Borg Grippers a Bit More, Adds Mining Gripper. Borgs Drop Items in Storage Modules if Gibbed. #25511
Merged
+98
−58
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ParadiseSS13-Bot
added
the
-Status: Awaiting type assignment
This PR is waiting for its type to be assigned internally
label
May 18, 2024
Oyu07
reviewed
May 18, 2024
Co-authored-by: Deniz <66401072+Oyu07@users.noreply.github.com> Signed-off-by: CRUNCH <143041327+Fordoxia@users.noreply.github.com>
ParadiseSS13-Bot
added
-Status: Awaiting approval
This PR is waiting for approval internally
-Status: Awaiting review
This PR is awaiting review from the review team
and removed
-Status: Awaiting type assignment
This PR is waiting for its type to be assigned internally
-Status: Awaiting approval
This PR is waiting for approval internally
labels
May 18, 2024
Sirryan2002
approved these changes
May 30, 2024
ParadiseSS13-Bot
added
-Status: Awaiting merge
This PR is ready for merge
and removed
-Status: Awaiting review
This PR is awaiting review from the review team
labels
May 30, 2024
Signed-off-by: CRUNCH <143041327+Fordoxia@users.noreply.github.com>
lewcc
reviewed
Jun 6, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
One quick thing.
lewcc
approved these changes
Jun 12, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What Does This PR Do
Refactors the borg gripper, mostly the
afterattack
chain, it's nicer now.Borgs with storage-capable items such as the trash bag or mining satchel will now dump the contents of those items on the floor when gibbed (in line with how the service borg tray is handled already).
Adds the mining gripper. It can hold 3 things:
This also fixes #25512 (and fixes #25648, which is a duplicate issue).
Why It's Good For The Game
Nicer code is good.
Considering that when carbons are gibbed, they drop the stuff they're carrying, it makes sense to extend this to the non-module/component items a borg might have too.
Mining borgs have it rough, they aren't ignored by fauna, and are also locked out of the lavaland combat rewards entirely. This throws them a little bone to gnaw on.
Bug bad, oops.
Testing
It compiled.
Made one of every borg with every variant of storage-capable item. Filled them up, gibbed them, the items all dropped.
Became mining borg. Was able to grab a pickaxe and mine. Was able to make shelter. Was able to grab goliath plating and armour myself with it. Tested and verified the armour actually worked.
Became Service, Medical, and Enginering borg. Verified that all their gripper functions still worked as before.
Changelog
🆑
add: Adds a mining gripper for the mining borg. It can hold and use goliath plates (for self armouring), shelter capsules (for shelter), and pickaxes (for old fashioned mining).
/:cl: