fix: better handling of whiteship signaller input #25531
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ParadiseSS13-Bot
added
-Status: Awaiting type assignment
Burzah
approved these changes
May 21, 2024
ParadiseSS13-Bot
added
-Status: Awaiting merge
|
This pull request seems to be stale as there have been no changes in 14 days, please make changes within 7 days or the PR will be closed. If you believe this is a mistake, please inform a development team member on Discord. |
github-actions
bot
added
the
Stale
lewcc
approved these changes
Jun 6, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What Does This PR Do
This PR fixes issues with the whiteship signaller, where pressing cancel on the TGUI input for naming the port would still accidentally create a port. It also fixes an issue where pressing cancel on the TGUI input for choosing the port direction would not delete the port (we create the port that early because we want to use its ability to determine all the affected turfs to see if there's anything in them). It also adds more descriptive messages for when any step of the process is cancelled. Fixes #25530.
Why It's Good For The Game
Bugs bad.
Images of changes
output.mp4
Testing
Spawned in, verified cancelling at every step worked. Also tested that emptying the text field also cancelled placement (not in the video).
Changelog
馃啈
fix: The whiteship signaller now properly handles cancelling at any step.
/:cl: