New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: update phpunit to version 9 #932
Conversation
Tests are failing because of deprecation warnings for PhpUnit 10. |
15d0c6e
to
a71432c
Compare
@Chris53897 Thanks for working on this! I agree this PR was just getting too big. I have made some smaller changes on the master branch (updating version to 2.x, removing PHP 7 from composer, removing travis config file (since travis hasn't been used for a while) etc). I have also reverted the commit that added all the types, so that we can focus only on the PHPUnit update in this PR. Other changes can then be made in separate smaller PRs targeting the master branch. For things like adding type-hints, I also think it should be done incrementally and not all in one go (E.G take a few interfaces, add the types, and do the next few in another PR), just to make it easy to review and ensure we can revisit the types. |
@pierredup thanks for having a look. I am already working on an PR in the meantime for typehints. I will try to get tests working and will respond here after that is done. |
56e4886
to
d2b6a45
Compare
d2b6a45
to
da053ac
Compare
aff7162
to
a7c2208
Compare
As discussed in #928 this is the first task needed for modernization (in my point of view).
There is of course a lot of space for improvments. But i do not want to do, to many things at once.
@pierredup @johnkrovitch
Maybe you can branch from
master
a new develop-branch2.x
for modernization.So i can take new branch as base for this PR. Advantage:
master
stays clean for other changes.From that point we can improve that branch by ...
[ ] Add Typehints on internal API (avoid BC breaks)
[ ] Use new Language Features of PHP 8
[ ] Remove external deprecations (PhpUnit, ...)
[ ] Move Travis to github actions (Run tests on each repo separately)
[ ] Update Dependencies: Example: Possible BC Break: php-http/guzzle6-adapter => php-http/guzzle7-adapter
[ ] TODO
And after all that is done, new Interfaces and more complex code changes can be done.
So this single PR ist not getting bigger and bigger.
WDYT?