[Paypal express-checkout-nvp] Inconsistency in Transaction Status Key Naming

[ViniTou]

Greetings,

I've outlined the logic flow below and would appreciate corrections if any discrepancies are identified:

1. Incoming Notify Action: Initiates the \Payum\Paypal\ExpressCheckout\Nvp\Action\PaymentDetailsSyncAction.

2. Within the PaymentDetailsSyncAction, transactions are fetched for each transaction in a loop:

   foreach (range(0, 9) as $index) {
       if ($model['PAYMENTREQUEST_'.$index.'_TRANSACTIONID']) {
           $this->gateway->execute(new GetTransactionDetails($model, $index));
       }

3. The response for these transactions is stored in the model through the GetTransactionDetailsAction:

   $result = $this->api->getTransactionDetails(array('TRANSACTIONID' => $model[$transactionIndex]));
   foreach ($result as $name => $value) {
       if (in_array($name, $this->getPaymentRequestNFields())) {
           $model['PAYMENTREQUEST_'.$request->getPaymentRequestN().'_'.$name] = $value;
       }
   }

   Note: Each value is stored under a key with the PAYMENTREQUEST_ prefix.

4. The complete model is intended to be used with GetHumanStatus. However, there appears to be an issue with the checks for transaction status, as they reference values under the wrong key in PaymentDetailsStatusAction.php:

   src/Payum/Paypal/ExpressCheckout/Nvp/Action/PaymentDetailsStatusAction.php:95
   foreach (range(0, 9) as $index) {
       if (null === $paymentStatus = $model['PAYMENTINFO_'.$index.'_PAYMENTSTATUS']) {
           continue;
       }

   Question: Is there a reason why this setup might not be working, or is it a case of misnamed keys? If the latter, should the key in PaymentDetailsStatusAction be updated?

Your insights on this matter would be highly valuable. Thank you.

[pierredup]

@ViniTou The checks are correct.

When a payment is initiated, the PAYMENTREQUEST_ values are set and sent to PayPal. Once the payment on PayPal is done and the user is directed back to the site, then the payment is captured. When the payment is captured, before the Sync action is executed, the DoExpressCheckoutPayment action is executed which triggers the DoExpressCheckoutPaymentAction

Payum/src/Payum/Paypal/ExpressCheckout/Nvp/Action/PurchaseAction.php

Lines 82 to 101 in c8da4ce

	if (
	$details['PAYERID'] &&
	Api::CHECKOUTSTATUS_PAYMENT_ACTION_NOT_INITIATED === $details['CHECKOUTSTATUS'] &&
	$details['PAYMENTREQUEST_0_AMT'] > 0
	) {
	if (Api::USERACTION_COMMIT !== $details['AUTHORIZE_TOKEN_USERACTION']) {
	$confirmOrder = new ConfirmOrder($request->getFirstModel());
	$confirmOrder->setModel($request->getModel());
	$this->gateway->execute($confirmOrder);
	}
	$this->gateway->execute(new DoExpressCheckoutPayment($details));
	}
	if (! $details['PAYERID']) {
	$this->gateway->execute(new AuthorizeToken($details));
	}
	$this->gateway->execute(new Sync($details));

The DoExpressCheckoutPaymentAction then calls the PayPal API with the payment fields. The API then responds with all the PAYMENTINFO_ fields, which is then added back into the model.

Payum/src/Payum/Paypal/ExpressCheckout/Nvp/Action/Api/DoExpressCheckoutPaymentAction.php

Lines 44 to 46 in c8da4ce

	$model->replace(
	$this->api->doExpressCheckoutPayment((array) $model)
	);

So when the PaymentDetailsStatusAction action is executed the values is checking against the correct keys that are set on the model.

If there is something specific not working for you, please let me know what issues you are facing.

[pierredup]

If there are any other issues, please feel free to re-open the issue and add additional detail

[ViniTou]

Thing is I was not talking about capturing payment, as that works fine, but Notify action flow.