Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

_R_CHECK_LENGTH_1_CONDITION_ not needed after R 4.2.0 #3177

Open
infotroph opened this issue Jun 3, 2023 · 2 comments
Open

_R_CHECK_LENGTH_1_CONDITION_ not needed after R 4.2.0 #3177

infotroph opened this issue Jun 3, 2023 · 2 comments

Comments

@infotroph
Copy link
Member

infotroph commented Jun 3, 2023

User-visible changes in R 4.2 included:

Calling if() or while() with a condition of length greater than one gives an error rather than a warning. Consequently, environment variable _R_CHECK_LENGTH_1_CONDITION_ no longer has any effect.

In a future version bump when we stop testing R < 4.2.0, we can stop setting _R_CHECK_LENGTH_1_CONDITION_ in ci.yml and elsewhere.

@Sweetdevil144
Copy link
Contributor

Sweetdevil144 commented Jan 28, 2024

I guess the following checks are present only in .github/workflows/ci-weekly.yml and .github/workflows/ci.yml.
Also, I guess the behavior controlled by R_CHECK_LENGTH_1_CONDITION is now the default behavior, and thus the environment variable no longer has any effect.
What are your views regarding this @infotroph ?

@infotroph
Copy link
Member Author

It's the default from R 4.2.0 onward, but since we still support R 4.1 (and in fact that's the main version we test on!), I don't think we're ready to remove these yet.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants