Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Future-proof the table ordering stuff #82

Open
davorg opened this issue Aug 8, 2023 · 0 comments
Open

Future-proof the table ordering stuff #82

davorg opened this issue Aug 8, 2023 · 0 comments

Comments

@davorg
Copy link
Collaborator

davorg commented Aug 8, 2023

I've just fixed the mechanism that lets an author define a default order for the table on their page (see 14a4215). This had never worked (because it needed a column number and we were using names) and it had broken even more when I added another column without fixing the numbers in the JS config.

I'll be adding columns and maybe moving columns about in the future, so the current approach isn't scalable. We need to go back to allowing authors to specify their default sort column by name - and then have a hash to convert that to a number.

Maybe also think about storing the current sort order in a cookie.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant