Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support exporting OTLP over gRPC #1090

Open
jbergstroem opened this issue Feb 27, 2024 · 9 comments · May be fixed by #1095
Open

Support exporting OTLP over gRPC #1090

jbergstroem opened this issue Feb 27, 2024 · 9 comments · May be fixed by #1095
Labels
💎 Bounty feature request New feature or request go Pull requests that update Go code

Comments

@jbergstroem
Copy link
Contributor

jbergstroem commented Feb 27, 2024 •
edited

Is your feature request related to a problem? Please describe.
The OTLP exporter for tracers, logs and metrics currently are hardcoded to use HTTP. It would be great if it optionally supported gRPC as well:

permify/pkg/telemetry/meterexporters/otlp.go

Lines 11 to 15 in c4e26ce

func NewOTLP(endpoint string, insecure bool, urlpath string) (metric.Exporter, error) {
options := []otlpmetrichttp.Option{
otlpmetrichttp.WithCompression(otlpmetrichttp.GzipCompression),
otlpmetrichttp.WithEndpoint(endpoint),
}

Describe the solution you'd like

  1. expand the meter/logging/tracing config with a sub object called oltp containing protocol (if this is the only option that supports gRPC. If supported by multiple libraries I'd keep it at the top level.
  2. branch on above option (which defaults to http) and invoke the different exporter.

Describe alternatives you've considered
Stick with HTTP
@jbergstroem jbergstroem added the feature request New feature or request label Feb 27, 2024
@tolgaOzen
Copy link
Member

/bounty $200

@algora-pbc Algora PBC
Copy link

algora-pbc bot commented Feb 27, 2024 •
edited

💎 $200 bounty • Permify.co

Steps to solve:

  1. Start working: Comment /attempt #1090 with your implementation plan
  2. Submit work: Create a pull request including /claim #1090 in the PR body to claim the bounty
  3. Receive payment: 100% of the bounty is received 2-5 days post-reward. Make sure you are eligible for payouts

Don't wait to be assigned. A reward will be given for the best PR.

Additional opportunities:

Thank you for contributing to Permify/permify!

Add a bounty • Share on socials

Attempt Started (GMT+0) Solution
🟢 @berkeli Feb 27, 2024, 6:21:43 PM WIP
🟢 @avanaur Apr 21, 2024, 10:05:39 AM #1197
🟢 @mohanish2504 #1095

@tolgaOzen tolgaOzen added the go Pull requests that update Go code label Feb 27, 2024
@mohanish2504
Copy link
Contributor

Can i attempt

@joshauh46
Copy link

Hi, can I work on this?

@berkeli
Copy link
Contributor

berkeli commented Feb 27, 2024 •
edited by algora-pbc bot

/attempt 1090

Algora profile Completed bounties Tech Active attempts Options
@berkeli 2 Permify bounties
HTML, JavaScript,
Shell & more
Cancel attempt

@algora-pbc algora-pbc bot mentioned this issue Feb 27, 2024
Closed
@tolgaOzen
Copy link
Member

tolgaOzen commented Feb 27, 2024 •
edited by algora-pbc bot

Hello @mohanish2504, I had assigned you, but we've decided to proceed differently. From now on, let anyone /attempt and submit PRs without needing to be assigned and we will reward the best PR.

Options

@mohanish2504 mohanish2504 linked a pull request Feb 27, 2024 that will close this issue
Open
@algora-pbc Algora PBC
Copy link

algora-pbc bot commented Feb 27, 2024

💡 @mohanish2504 submitted a pull request that claims the bounty. You can visit your bounty board to reward.

@avanaur
Copy link
Contributor

avanaur commented Apr 21, 2024 •
edited by algora-pbc bot

/attempt #1090

Options

@algora-pbc Algora PBC
Copy link

algora-pbc bot commented Apr 21, 2024 •
edited

💡 @avanaur submitted a pull request that claims the bounty. You can visit your bounty board to reward.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
💎 Bounty feature request New feature or request go Pull requests that update Go code
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat: otlp with grpc mohanish2504/permify
7 participants
@jbergstroem @avanaur @berkeli @EgeAytin @tolgaOzen @mohanish2504 @joshauh46