Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Windows .exe misses version info #133

Open
TheLastProject opened this issue Oct 1, 2018 · 4 comments
Open

Windows .exe misses version info #133

TheLastProject opened this issue Oct 1, 2018 · 4 comments

Comments

@TheLastProject
Copy link
Member

The macOS .dmg has a version number such as Pext-0.19.29.g659fb76.dmg.

The version can be retrieved by running python setup.py (which will fail, but also save the correct version to pext/VERSION).

It would be great if this could be added to the .exe filename and the NSIS installer (and uninstall area on Windows) in .appveyor.yaml.

Probably very easy for someone who actually knows Windows, but I'm too Linux for this :)

@devansh289
Copy link

I'll start on this.

@TheLastProject
Copy link
Member Author

Tell me if you need any help :)

@TangentFoxy
Copy link
Contributor

I don't know what conda is, but it seems to me a good place to run python setup.py to get the version info would be after installing requirements (line 12)?

How would I make sure this failing doesn't cause the entire build to fail?

@TheLastProject
Copy link
Member Author

Under Linux you'd do something like python3 setup.py || true to always give a positive error code. I'm not sure what would be the Windows equivalent of this in AppVeyor

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

No branches or pull requests

3 participants