Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

NoopQuery elements result in invalid query bodies #2335

Closed
KGoodale13 opened this issue Mar 1, 2021 · 1 comment · Fixed by #3078
Closed

NoopQuery elements result in invalid query bodies #2335

KGoodale13 opened this issue Mar 1, 2021 · 1 comment · Fixed by #3078

Comments

@KGoodale13
Copy link

Currently using the NoopQuery value results in an invalid query body being generated. This is because NoopQuery values become empty objects in the body.

Example:

{
    "bool": {
        "should": [
           {}
        ]
    }
}

Instead I believe NoopQuery values should be removed from the body entirely, because an empty condition array is still a valid query.

Example:

{
    "bool": {
        "should": [
        ]
    }
}
@stale
Copy link

stale bot commented Apr 30, 2021

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants