-
Notifications
You must be signed in to change notification settings - Fork 85
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Please be mindful of the versions #161
Comments
There's more trouble. Since Downloading that tarball, as our tooling does, results in a tarball that is not a tarball, but a text file with the following line in it:
To avoid this in the future, either prefix the tags with a |
Note that it’s possible to work around this by writing the URL as https://github.com/Phlya/adjustText/archive/refs/tags/0.8.1/adjustText-0.8.1.tar.gz instead, although this is not ideal. |
Indeed. Another option for Fedora packagers fond of forge macros is to use the commit hash for the tag. Something like:
|
Thank you all for the comments. I just released a new version (1.0!), did I do it correctly? |
Well, it's a match (kind of). Looking in |
Good point, I missed that indeed.
I thought this meant adding a v prefix would be a good idea? And indeed, I have used this system in other projects in collaboration with others where we are more careful with versions etc... |
Indeed, this was one of the options I suggested. Both will work. It's not a question of right or wrong. In these circumstances, I, personally, would have gone for a different branch name. Branches are bit more flexible with regards to renames. But if you stick with the |
Someone else asked to review whether depending on bioframe is necessary, and I just copied over two necessary functions from there. So you don't need to wait for the bioframe review... I released some new versions, only the latest one (1.0.3) is packaged correctly :) |
Oh well, it just got reviewed and is now available in Fedora's rawhide repo. I'll keep it for now. If it turns out to be a burden I can always retire it again later. But thanks for looking into it and making the required changes dropping bioframe as a dependency.
As the saying goes: the third time is the charm. ;) Or maybe not... (see #168) |
Oh well, that's embarassing! I noticed this import was a problem for building the docs, so I removed it - should have realized it's an issue in general! I'll make a new minor release now... Thank you for letting me know! |
I encountered several issues with the version of the package.
In tag:
0.8.1
:adjustText/adjustText/_version.py
Line 1 in e3904a1
In tag
0.8
:adjustText/adjustText/_version.py
Line 1 in cb8b09d
In tag
0.7.3
:adjustText/setup.py
Line 6 in 354cbae
Either make this a release step and test that it is set correctly or use tooling that automatically adjusts the version according to the latest tag.
Right now, this would lead to issues when upgrading the package in Fedora. For example, I just built
0.8
and that has:The last two lines are taken from whatever the wheel provides. They should be corresponding to the actual version.
The text was updated successfully, but these errors were encountered: