Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change default local site TLD #94

Open
philipnewcomer opened this issue Jan 8, 2018 · 5 comments
Open

Change default local site TLD #94

philipnewcomer opened this issue Jan 8, 2018 · 5 comments
Assignees
Milestone

Comments

@philipnewcomer
Copy link
Member

Since Chrome is now forcing all .dev domains to use HTTPS, we should change the default TLD for local sites to something else, I propose .localhost. However, this new default TLD should be configurable in the Pilothouse config file, as there does not appear to be a consensus in the industry on what the new local host TLD should be, and some folks may still want to use .dev by default if HTTPS is not a problem for their local sites.

@philipnewcomer philipnewcomer added this to the 1.0 milestone Jan 8, 2018
@philipnewcomer philipnewcomer self-assigned this Jan 8, 2018
@AaronHolbrook
Copy link
Member

Agreed - and it's going to take a while to switch all existing sites/etc and change our frame of mind

@philipnewcomer
Copy link
Member Author

I saw in the most recent Docker update release notes that "there is an RFC banning the use of subdomains of localhost". We may want to reconsider the default local site TLD of .localhost.

screen shot 2018-01-11 at 9 29 04 am

@philipnewcomer
Copy link
Member Author

.localhost is definitely going to be a problem. Subdomains of localhost will always be resolved directly to 127.0.0.1 by the operating system, bypassing any hosts file entries. That would be an advantage on the host, eliminating the need for hosts file entries. However, that would also make it so that PHP scripts would be unable to connect back to themselves through the Nginx container, since the site URL would always resolve to the Docker container the code is running in, and the PHP containers do not accept HTTP connections. A PHP script could never make a connection to sitename.localhost. That would, for instance, break WP cron.

@Jaace
Copy link
Contributor

Jaace commented Jan 25, 2018

I have started using .test for my sites.

@AaronHolbrook
Copy link
Member

AaronHolbrook commented Jan 26, 2018 via email

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants