Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dependency issue in this package #8

Open
riteshkmr33 opened this issue Aug 4, 2017 · 1 comment
Open

Dependency issue in this package #8

riteshkmr33 opened this issue Aug 4, 2017 · 1 comment

Comments

@riteshkmr33
Copy link

It's mentioned on package that there is no dependency :
screen shot 2017-08-04 at 3 36 19 pm

But after installation it gave me error :
├── UNMET PEER DEPENDENCY react@15.4.2
├── UNMET PEER DEPENDENCY socket.io-client@2.0.3
└── socket.io-react@1.2.0

While if you see my package json :
"react": "15.4.2",
"socket.io-client": "2.0.3",
"socket.io-react": "1.2.0",

All the required packages are already there. Please test your plugin once before publishing.

@sergiodxa
Copy link
Contributor

@riteshkmr33,

The peer dependencies of this module are:

{
  "socket.io-client": "^1.4.5",
  "prop-types": "^15.5.10",
  "react": "^15.6.1"
}

And you installed socket.io-client@2.0.3 and react@15.4.2 so you don't meet both peer dependencies (you need a greater react version and a lower socket.io-client version).

Please learn about peer dependencies and semver once before talking shit.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants