-
Notifications
You must be signed in to change notification settings - Fork 57
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Several error in the documentation #18
Comments
That @garlicnation @arthurevans any ideas? |
I don't think that you should need to escape that one bracket (weird that it's the second-to-last-one, too). But um ah I'm probably wrong? |
That one bracket makes |
On a scale of 1 to bad that seems really bad. @garlicnation is this a known issue with hydrolysis? |
Hi @notwaldorf @arthurevans @garlicnation , in order to help, I think that the tag should be written like this '</\script>'. This change does not fix the issue but, I 've made a test using the demo of the `iron-doc-viewer' component and, if you use this syntax, the tag is parsed ok. I think that hydrolysis should take care of this syntax, escaping the slash. |
Hi again @notwaldorf @arthurevans @garlicnation, another idea.. after some tests over the
with this
That is to say, an small fix to find and replace a pattern for the script and replace with the correct value. After that, you can view the documentation with the script tag fixed: But, really I am not sure if this is the best place to make the fix. I mean, maybe this small parse should be inside hydrolysis. |
Description
There are several small errors in the documentation of this element.
Just one example:
Expected outcome
</script>
Actual outcome
</script>
I will fix this errors and I will propose a PR soon to fix this issue.
The text was updated successfully, but these errors were encountered: