Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fwlink helpURI of Get-Uptime,Get-FileHash and others doesn't work #23069

Closed
5 tasks done
Ashc0d opened this issue May 9, 2024 · 5 comments
Closed
5 tasks done

fwlink helpURI of Get-Uptime,Get-FileHash and others doesn't work #23069

Ashc0d opened this issue May 9, 2024 · 5 comments
Assignees
Labels
Issue-Bug Issue has been identified as a bug in the product Resolution-Fixed The issue is fixed.

Comments

@Ashc0d
Copy link

Ashc0d commented May 9, 2024

Prerequisites

Steps to reproduce

The helpURI forward link for Get-Uptime does not lead to its powershell documentation.
Last work done on Get-Uptime related to helpURI was in #2688.

I believe helpURI in these two following file needs to be updated to fix this issue after getting fwlink.

  • PowerShell/test/powershell/engine/Help/assets/HelpURI/V3Cmdlets.csv

Inline:

Get-Uptime,https://go.microsoft.com/fwlink/?linkid=834862

  • PowerShell/src/Microsoft.PowerShell.Commands.Utility/commands/utility/GetUptime.cs

Inline:

[Cmdlet(VerbsCommon.Get, "Uptime", DefaultParameterSetName = TimespanParameterSet, HelpUri = "https://go.microsoft.com/fwlink/?linkid=834862")]

Expected behavior

PS> Get-Help Get-Uptime -Online

Should open link: https://learn.microsoft.com/en-us/powershell/module/microsoft.powershell.utility/get-uptime?view=powershell-7.4

Actual behavior

PS> Get-Help Get-Uptime -Online

Open's link after redirection: https://www.bing.com/?ref=go&linkid=834862

Error details

No response

Environment data

Name                           Value
----                           -----
PSVersion                      7.4.2
PSEdition                      Core
GitCommitId                    7.4.2
OS                             Microsoft Windows 10.0.22631
Platform                       Win32NT
PSCompatibleVersions           {1.0, 2.0, 3.0, 4.0…}
PSRemotingProtocolVersion      2.3
SerializationVersion           1.1.0.1
WSManStackVersion              3.0

Visuals

No response

@Ashc0d Ashc0d added the Needs-Triage The issue is new and needs to be triaged by a work group. label May 9, 2024
@SteveL-MSFT
Copy link
Member

cc @sdwheeler

@SteveL-MSFT SteveL-MSFT added Issue-Bug Issue has been identified as a bug in the product and removed Needs-Triage The issue is new and needs to be triaged by a work group. labels May 10, 2024
@Ashc0d
Copy link
Author

Ashc0d commented May 10, 2024

Found several another cmdlet that does not have correct fwlink helpURI:

Get-FileHash https://go.microsoft.com/fwlink/?LinkId=517145

Get-LocalGroupMember https://go.microsoft.com/fwlink/?LinkId=717988

Get-LocalUser https://go.microsoft.com/fwlink/?LinkId=717980

Remove-LocalGroup https://go.microsoft.com/fwlink/?LinkId=717975

Get-LocalGroup https://go.microsoft.com/fwlink/?LinkId=717974

there can be more cmdlets that have same problems.

Bing
This pristine aquatic sanctuary so pristine that i
Bing
This pristine aquatic sanctuary so pristine that i
Bing
This pristine aquatic sanctuary so pristine that i
Bing
This pristine aquatic sanctuary so pristine that i
Bing
This pristine aquatic sanctuary so pristine that i

@Ashc0d Ashc0d changed the title fwlink helpURI of Get-Uptime doesn't work fwlink helpURI of Get-Uptime,Get-FileHash and others doesn't work May 10, 2024
@sdwheeler
Copy link
Collaborator

There were a total of 34 links that got deactivated. These have been restored.

@sdwheeler sdwheeler self-assigned this May 13, 2024
@sdwheeler sdwheeler added the Resolution-Fixed The issue is fixed. label May 13, 2024
@Ashc0d
Copy link
Author

Ashc0d commented May 14, 2024

Great, I will close this issue now.

@Ashc0d Ashc0d closed this as completed May 14, 2024
Copy link
Contributor

microsoft-github-policy-service bot commented May 14, 2024

📣 Hey @Ashc0d, how did we do? We would love to hear your feedback with the link below! 🗣️

🔗 https://aka.ms/PSRepoFeedback

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Issue-Bug Issue has been identified as a bug in the product Resolution-Fixed The issue is fixed.
Projects
None yet
Development

No branches or pull requests

3 participants