Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Blurry effect on edit and delete submenu icons on migrated pages #14001

Closed
colinegin opened this issue May 28, 2019 · 11 comments
Closed

Blurry effect on edit and delete submenu icons on migrated pages #14001

colinegin opened this issue May 28, 2019 · 11 comments
Assignees
Labels
BO Category: Back Office Bug Type: Bug Fixed Resolution: issue closed because fixed Front-end Category: Front end migration symfony migration project Trivial Severity: trivial bug > https://build.prestashop.com/news/severity-classification
Milestone

Comments

@colinegin
Copy link

In newly migrated pages, there is a "blurry" effect on submenu icons for edit and remove options. This might be related to a change in their size, which should not happen.
Ex :
image

@colinegin colinegin added BO Category: Back Office Trivial Severity: trivial bug > https://build.prestashop.com/news/severity-classification labels May 28, 2019
@colinegin colinegin added this to Backlog in PrestaShop 1.7.6 via automation May 28, 2019
@sarjon
Copy link
Contributor

sarjon commented May 28, 2019

This happened to me before as well, make sure your browser zoom is at 100%, but I guess it should be fixed anyway.

@marionf marionf added Bug Type: Bug migration symfony migration project labels Jun 7, 2019
@zuk3975
Copy link
Contributor

zuk3975 commented Jun 11, 2019

I found out that this behavior is associated with bootstrap dropdown, so i doubt we can do anything.
The thing is that on toggle it puts style with transform:translate3d('x', 'y', 0) and this causes the blur. There are workarounds for this particular css attribute (for example putting transform:translateX('x') translateY('y')), but we cannot change the behavior of bootstrap anyway.

@colinegin
Copy link
Author

Alright thanks for your feedback @zuk3975 , since there's nothing we can do yet, I remove it from the 1.7.6 kanban.
@matks , for a future version we'll see if there's something we can do to improve it.

@colinegin colinegin removed this from Backlog in PrestaShop 1.7.6 Jun 12, 2019
@colinegin colinegin added the Front-end Category: Front end label Feb 3, 2020
@davidglezz
Copy link
Contributor

davidglezz commented Feb 19, 2020

It is easy to fix adding single line of code.

You can just turn off the transform placement on Popper to make it only use top/left for positioning instead. Then you can use transform for any animations/transitions as you wish.

Popper.Defaults.modifiers.computeStyle.gpuAcceleration = false;

twbs/bootstrap#23378 (comment)

@NeOMakinG
Copy link

Still unfixable without a bootstrap update of UIKit and BO Themes

@colinegin
Copy link
Author

Alright so I guess this will be fixed with 178 once the UI kit has been updated ?

@NeOMakinG
Copy link

Well it seems like I can yes, gonna work on this

@colinegin colinegin added this to Backlog in PrestaShop 1.7.8.0 via automation Mar 5, 2020
@colinegin colinegin moved this from Backlog to To do in PrestaShop 1.7.8.0 May 14, 2020
@prestashop-issue-bot prestashop-issue-bot bot added the Ready Status: Issue is ready to be worked on label May 14, 2020
@LouiseBonnard LouiseBonnard moved this from To do to Need more specs/Blocked in PrestaShop 1.7.8.0 Jul 13, 2020
@prestashop-issue-bot prestashop-issue-bot bot added Needs Specs Status: issue needs to be specified and removed Ready Status: Issue is ready to be worked on labels Jul 13, 2020
@LouiseBonnard
Copy link
Contributor

On hold, waiting for the merge of the UI kit.

@LouiseBonnard LouiseBonnard added Ready Status: Issue is ready to be worked on and removed Needs Specs Status: issue needs to be specified labels Aug 24, 2020
@prestashop-issue-bot prestashop-issue-bot bot moved this from Need more specs/Blocked to To do in PrestaShop 1.7.8.0 Aug 24, 2020
@LouiseBonnard LouiseBonnard moved this from To do to Need more specs/Blocked in PrestaShop 1.7.8.0 Aug 24, 2020
@prestashop-issue-bot prestashop-issue-bot bot added Needs Specs Status: issue needs to be specified and removed Ready Status: Issue is ready to be worked on labels Aug 24, 2020
@davidglezz
Copy link
Contributor

@NeOMakinG
Copy link

@davidglezz It will probably fixed on next uikit release, or on new major version :/

I say that because we noticed that it wasn't here with uikit on the develop branch, but overwhise it will probably be fixed later with the PR you linked, thanks :)

@NeOMakinG
Copy link

Looks fine now on develop, should be fixed :)

PrestaShop 1.7.8.0 automation moved this from Need more specs/Blocked to Done Nov 13, 2020
@NeOMakinG NeOMakinG added the Fixed Resolution: issue closed because fixed label Nov 13, 2020
@NeOMakinG NeOMakinG added this to the 1.7.8.0 milestone Nov 13, 2020
@LouiseBonnard LouiseBonnard removed this from the 1.7.8.0 milestone Nov 13, 2020
@marionf marionf added this to the 1.7.8.0 milestone Dec 14, 2020
@hibatallahAouadni hibatallahAouadni removed the Needs Specs Status: issue needs to be specified label Jan 19, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
BO Category: Back Office Bug Type: Bug Fixed Resolution: issue closed because fixed Front-end Category: Front end migration symfony migration project Trivial Severity: trivial bug > https://build.prestashop.com/news/severity-classification
Projects
No open projects
Development

No branches or pull requests

8 participants