Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Whitespace is being added around spans #113

Open
thedamon opened this issue Aug 17, 2019 · 7 comments
Open

Whitespace is being added around spans #113

thedamon opened this issue Aug 17, 2019 · 7 comments
Labels
bug Something isn't working help wanted Extra attention is needed

Comments

@thedamon
Copy link

🐛 Bug Report

white space is being added in between spans with no discernible way to stop it

To Reproduce

Steps to reproduce the behavior:

Paste your markup here:

      <h1>emergen<span class="t">t</span><wbr /><span
          class="dot"
          aria-hidden
        ></span>seas
      </h1>

Expected behavior

the t is part of the word 'emergent', so if it needs to not have a space in front of it. The formatting should not change the resulting markup.

Current Results:

<h1>
  emergen
  <span class="t">t</span>
  <wbr />
  <span class="dot" aria-hidden></span>seas
</h1>

We are getting spaces inserted around the t, the <wbr> tag

Your Environment

https://prettyhtml.netlify.com/

@StarpTech
Copy link
Member

Hi @thedamon would you like to send a PR?

@StarpTech StarpTech added bug Something isn't working help wanted Extra attention is needed labels Aug 17, 2019
@thedamon
Copy link
Author

I don't think i have the expertise or time to look at this within a reasonable timeframe.
I suspect there may be some complications involved in determining exactly how to compute line wrapping without changing the whitespace

@StarpTech
Copy link
Member

My time is also very limited and it has currently no priority. Feel free to ask for a starting point otherwise go with prettier as formatting tool.

@thedamon
Copy link
Author

Prettier team refuses to let us wrap attributes 1 per line so prettyhtml is my friend 😍

I could see where this would get hard to want to maintain with prettier doing much the same thing. If you know roughly where I might look I'd be curious to have a look and maaaaybe come up with something.

@ThD-Rizer
Copy link

@thedamon hello. Isn't that a solution to your problem?

@thedamon
Copy link
Author

thedamon commented Oct 19, 2019 via email

@y912765390

This comment was marked as spam.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working help wanted Extra attention is needed
Projects
None yet
Development

No branches or pull requests

4 participants