Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Minified CSS? #135

Closed
hoonweiting opened this issue Sep 12, 2021 · 2 comments · Fixed by #136
Closed

Minified CSS? #135

hoonweiting opened this issue Sep 12, 2021 · 2 comments · Fixed by #136

Comments

@hoonweiting
Copy link
Contributor

Currently working on #134, and wow, my file has surpassed 8kB, and I'm still not done! (Though to be fair, I have several lines' worth of comments at the top.) I was wondering if we could provide the minified versions of the CSS. While most of the themes weigh less than 5kB, I still think it'll be helpful overall, especially as Prism prides itself on being small.

I have seen #70 which was unfortunately closed by the OP due to unresponsiveness, as well as PrismJS/prism#2553 which has been pending for over eight months now.

I am also aware of the earlier PrismJS/prism#956 but I really don't think that "most people modify the CSS at least to a degree"... Even if this were the case, providing the minified CSS does not necessarily mean that we have to stop providing the non-minified ones.

I guess what I want to say overall is, we should give users the convenience of having the minified files ready to go (which is in line with Prism's selling point of being really small), while also letting them have the non-minified one if they would rather modify it directly for their own uses.

@RunDevelopment
Copy link
Member

I'll make a PR adding minified themes.

Regarding themes over at Prism: PrismJS/prism#2553 seems to have gone stale. I'll try to finish it today.

@hoonweiting
Copy link
Contributor Author

Whoa, that's fast! Thank you so much for all your efforts :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants