Dockerfile: Fixed strings inside comments (#2428)

Strings inside comments broke comments. Comments are now greedy, so this can't happen anymore.
PrismJS · Jun 21, 2020 · 37273a6 · 37273a6
1 parent ff74a61
commit 37273a6
Show file tree

Hide file tree

Showing 4 changed files with 10 additions and 3 deletions.
diff --git a/components/prism-docker.js b/components/prism-docker.js
@@ -4,7 +4,10 @@ Prism.languages.docker = {
 		lookbehind: true
 	},
 	'string': /("|')(?:(?!\1)[^\\\r\n]|\\(?:\r\n|[\s\S]))*\1/,
-	'comment': /#.*/,
+	'comment': {
+		pattern: /#.*/,
+		greedy: true
+	},
 	'punctuation': /---|\.\.\.|[:[\]{}\-,|>?]/
 };
 

diff --git a/components/prism-docker.min.js b/components/prism-docker.min.js
diff --git a/examples/prism-docker.html b/examples/prism-docker.html
@@ -2,6 +2,8 @@ <h2>Comments</h2>
 <pre><code># These are the comments for a dockerfile.
 # I want to make sure $(variables) don't break out,
 # and we shouldn't see keywords like ADD or ENTRYPOINT
+
+# I also want to make sure that this "string" and this 'string' don't break out.
 </code></pre>
 
 <h2>Full example</h2>

diff --git a/tests/languages/docker/comment_feature.test b/tests/languages/docker/comment_feature.test
@@ -1,11 +1,13 @@
 #
 # foobar
+# "foo" 'bar'
 
 ----------------------------------------------------
 
 [
 	["comment", "#"],
-	["comment", "# foobar"]
+	["comment", "# foobar"],
+	["comment", "# \"foo\" 'bar'"]
 ]
 
 ----------------------------------------------------