Line Highlight: Ignore ranges outside of actual lines (#3475)

PrismJS · Jun 16, 2022 · 9a4e725 · 9a4e725
1 parent 6464271
commit 9a4e725
Show file tree

Hide file tree

Showing 2 changed files with 9 additions and 2 deletions.
diff --git a/plugins/line-highlight/prism-line-highlight.js b/plugins/line-highlight/prism-line-highlight.js
@@ -6,6 +6,7 @@
 
 	var LINE_NUMBERS_CLASS = 'line-numbers';
 	var LINKABLE_LINE_NUMBERS_CLASS = 'linkable-line-numbers';
+	var NEW_LINE_EXP = /\n(?!$)/g;
 
 	/**
 	 * @param {string} selector
@@ -136,7 +137,8 @@
 			var codeElement = pre.querySelector('code');
 			var parentElement = hasLineNumbers ? pre : codeElement || pre;
 			var mutateActions = /** @type {(() => void)[]} */ ([]);
-
+			var lineBreakMatch = codeElement.textContent.match(NEW_LINE_EXP);
+			var numberOfLines = lineBreakMatch ? lineBreakMatch.length + 1 : 1;
 			/**
 			 * The top offset between the content box of the <code> element and the content box of the parent element of
 			 * the line highlight element (either `<pre>` or `<code>`).
@@ -154,6 +156,11 @@
 
 				var start = +range[0];
 				var end = +range[1] || start;
+				end = Math.min(numberOfLines, end);
+
+				if (end < start) {
+					return;
+				}
 
 				/** @type {HTMLElement} */
 				var line = pre.querySelector('.line-highlight[data-range="' + currentRange + '"]') || document.createElement('div');

diff --git a/plugins/line-highlight/prism-line-highlight.min.js b/plugins/line-highlight/prism-line-highlight.min.js