From ebbbfd471b1688106adfa686a17151744a4affc4 Mon Sep 17 00:00:00 2001 From: XojoGermany <1276539+XojoGermany@users.noreply.github.com> Date: Mon, 22 Mar 2021 13:03:36 +0100 Subject: [PATCH] Xojo: `REM` is no longer highlighted as a keyword in comments (#2823) REM was incorrectly identified as a keyword. This has been fixed. REM is now recognized as a comment. --- components/prism-xojo.js | 7 ++----- components/prism-xojo.min.js | 2 +- tests/languages/xojo/comment_feature.test | 6 +++--- tests/languages/xojo/keyword_feature.test | 2 -- 4 files changed, 6 insertions(+), 11 deletions(-) diff --git a/components/prism-xojo.js b/components/prism-xojo.js index 9c6671e7fc..a1a514b60e 100644 --- a/components/prism-xojo.js +++ b/components/prism-xojo.js @@ -1,9 +1,6 @@ Prism.languages.xojo = { 'comment': { - pattern: /(?:'|\/\/|Rem\b).+/i, - inside: { - 'keyword': /^Rem/i - } + pattern: /(?:'|\/\/|Rem\b).+/i }, 'string': { pattern: /"(?:""|[^"])*"/, @@ -14,7 +11,7 @@ Prism.languages.xojo = { /&[bchou][a-z\d]+/i ], 'symbol': /#(?:If|Else|ElseIf|Endif|Pragma)\b/i, - 'keyword': /\b(?:AddHandler|App|Array|As(?:signs)?|Auto|By(?:Ref|Val)|Boolean|Break|Byte|Call|Case|Catch|CFStringRef|CGFloat|Class|Color|Const|Continue|CString|Currency|CurrentMethodName|Declare|Delegate|Dim|Do(?:uble|wnTo)?|Each|Else(?:If)?|End|Enumeration|Event|Exception|Exit|Extends|False|Finally|For|Function|Get|GetTypeInfo|Global|GOTO|If|Implements|In|Inherits|Int(?:erface|eger|8|16|32|64)?|Lib|Loop|Me|Module|Next|Nil|Object|Optional|OSType|ParamArray|Private|Property|Protected|PString|Ptr|Raise(?:Event)?|ReDim|Rem|RemoveHandler|Return|Select(?:or)?|Self|Set|Single|Shared|Short|Soft|Static|Step|String|Sub|Super|Text|Then|To|True|Try|Ubound|UInt(?:eger|8|16|32|64)?|Until|Using|Var(?:iant)?|Wend|While|WindowPtr|WString)\b/i, + 'keyword': /\b(?:AddHandler|App|Array|As(?:signs)?|Auto|By(?:Ref|Val)|Boolean|Break|Byte|Call|Case|Catch|CFStringRef|CGFloat|Class|Color|Const|Continue|CString|Currency|CurrentMethodName|Declare|Delegate|Dim|Do(?:uble|wnTo)?|Each|Else(?:If)?|End|Enumeration|Event|Exception|Exit|Extends|False|Finally|For|Function|Get|GetTypeInfo|Global|GOTO|If|Implements|In|Inherits|Int(?:erface|eger|8|16|32|64)?|Lib|Loop|Me|Module|Next|Nil|Object|Optional|OSType|ParamArray|Private|Property|Protected|PString|Ptr|Raise(?:Event)?|ReDim|RemoveHandler|Return|Select(?:or)?|Self|Set|Single|Shared|Short|Soft|Static|Step|String|Sub|Super|Text|Then|To|True|Try|Ubound|UInt(?:eger|8|16|32|64)?|Until|Using|Var(?:iant)?|Wend|While|WindowPtr|WString)\b/i, 'operator': /<[=>]?|>=?|[+\-*\/\\^=]|\b(?:AddressOf|And|Ctype|IsA?|Mod|New|Not|Or|Xor|WeakAddressOf)\b/i, 'punctuation': /[.,;:()]/ }; \ No newline at end of file diff --git a/components/prism-xojo.min.js b/components/prism-xojo.min.js index e2b92c08c7..0748cb6aed 100644 --- a/components/prism-xojo.min.js +++ b/components/prism-xojo.min.js @@ -1 +1 @@ -Prism.languages.xojo={comment:{pattern:/(?:'|\/\/|Rem\b).+/i,inside:{keyword:/^Rem/i}},string:{pattern:/"(?:""|[^"])*"/,greedy:!0},number:[/(?:\b\d+(?:\.\d*)?|\B\.\d+)(?:E[+-]?\d+)?/i,/&[bchou][a-z\d]+/i],symbol:/#(?:If|Else|ElseIf|Endif|Pragma)\b/i,keyword:/\b(?:AddHandler|App|Array|As(?:signs)?|Auto|By(?:Ref|Val)|Boolean|Break|Byte|Call|Case|Catch|CFStringRef|CGFloat|Class|Color|Const|Continue|CString|Currency|CurrentMethodName|Declare|Delegate|Dim|Do(?:uble|wnTo)?|Each|Else(?:If)?|End|Enumeration|Event|Exception|Exit|Extends|False|Finally|For|Function|Get|GetTypeInfo|Global|GOTO|If|Implements|In|Inherits|Int(?:erface|eger|8|16|32|64)?|Lib|Loop|Me|Module|Next|Nil|Object|Optional|OSType|ParamArray|Private|Property|Protected|PString|Ptr|Raise(?:Event)?|ReDim|Rem|RemoveHandler|Return|Select(?:or)?|Self|Set|Single|Shared|Short|Soft|Static|Step|String|Sub|Super|Text|Then|To|True|Try|Ubound|UInt(?:eger|8|16|32|64)?|Until|Using|Var(?:iant)?|Wend|While|WindowPtr|WString)\b/i,operator:/<[=>]?|>=?|[+\-*\/\\^=]|\b(?:AddressOf|And|Ctype|IsA?|Mod|New|Not|Or|Xor|WeakAddressOf)\b/i,punctuation:/[.,;:()]/}; \ No newline at end of file +Prism.languages.xojo={comment:{pattern:/(?:'|\/\/|Rem\b).+/i},string:{pattern:/"(?:""|[^"])*"/,greedy:!0},number:[/(?:\b\d+(?:\.\d*)?|\B\.\d+)(?:E[+-]?\d+)?/i,/&[bchou][a-z\d]+/i],symbol:/#(?:If|Else|ElseIf|Endif|Pragma)\b/i,keyword:/\b(?:AddHandler|App|Array|As(?:signs)?|Auto|By(?:Ref|Val)|Boolean|Break|Byte|Call|Case|Catch|CFStringRef|CGFloat|Class|Color|Const|Continue|CString|Currency|CurrentMethodName|Declare|Delegate|Dim|Do(?:uble|wnTo)?|Each|Else(?:If)?|End|Enumeration|Event|Exception|Exit|Extends|False|Finally|For|Function|Get|GetTypeInfo|Global|GOTO|If|Implements|In|Inherits|Int(?:erface|eger|8|16|32|64)?|Lib|Loop|Me|Module|Next|Nil|Object|Optional|OSType|ParamArray|Private|Property|Protected|PString|Ptr|Raise(?:Event)?|ReDim|RemoveHandler|Return|Select(?:or)?|Self|Set|Single|Shared|Short|Soft|Static|Step|String|Sub|Super|Text|Then|To|True|Try|Ubound|UInt(?:eger|8|16|32|64)?|Until|Using|Var(?:iant)?|Wend|While|WindowPtr|WString)\b/i,operator:/<[=>]?|>=?|[+\-*\/\\^=]|\b(?:AddressOf|And|Ctype|IsA?|Mod|New|Not|Or|Xor|WeakAddressOf)\b/i,punctuation:/[.,;:()]/}; \ No newline at end of file diff --git a/tests/languages/xojo/comment_feature.test b/tests/languages/xojo/comment_feature.test index c980136164..9e66f29171 100644 --- a/tests/languages/xojo/comment_feature.test +++ b/tests/languages/xojo/comment_feature.test @@ -5,9 +5,9 @@ Rem Foobar ---------------------------------------------------- [ - ["comment", ["' Foobar"]], - ["comment", ["// Foobar"]], - ["comment", [["keyword", "Rem"], " Foobar"]] + ["comment", "' Foobar"], + ["comment", "// Foobar"], + ["comment", "Rem Foobar"] ] ---------------------------------------------------- diff --git a/tests/languages/xojo/keyword_feature.test b/tests/languages/xojo/keyword_feature.test index f611dcfb3d..dd9e565d50 100644 --- a/tests/languages/xojo/keyword_feature.test +++ b/tests/languages/xojo/keyword_feature.test @@ -71,7 +71,6 @@ Ptr Raise RaiseEvent ReDim -Rem RemoveHandler Return Select @@ -183,7 +182,6 @@ WString ["keyword", "Raise"], ["keyword", "RaiseEvent"], ["keyword", "ReDim"], - ["keyword", "Rem"], ["keyword", "RemoveHandler"], ["keyword", "Return"], ["keyword", "Select"],