Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Website improvements #2053

Merged
merged 4 commits into from May 7, 2020
Merged

Website improvements #2053

merged 4 commits into from May 7, 2020

Conversation

RunDevelopment
Copy link
Member

  • Added a link to the download page in basic usage. I hope this clarifies TypeError: Cannot read property 'tokenizePlaceholders' of undefined #1400 a little.

  • Added UNPKG to the list of CDNs

  • Updated IE version support + usage statistic

  • Fixed typo

  • Added code for h2 links to make linking to specific sections easier. This adds a small visual distinction for h2s which makes sub-section more visible making it easier to mentally segment the page.
    The h2s won't appear in the TOC.

    image

Simran-B
Simran-B suggested changes Sep 16, 2019
View reviewed changes
Copy link
Contributor

@Simran-B Simran-B left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Longer <code> examples should start on a new line. Alternatively, a code block could be used.

test-suite.html Outdated Show resolved Hide resolved
test-suite.html Outdated Show resolved Hide resolved
@RunDevelopment
Copy link
Member Author

Thanks for the review @Simran-B!
I went with code blocks because they look better IMO.

@RunDevelopment
Copy link
Member Author

@mAAdhaTTah Can I merge this? Just some minor improvements to the website.

mAAdhaTTah
mAAdhaTTah approved these changes May 7, 2020
View reviewed changes
Copy link
Member

@mAAdhaTTah mAAdhaTTah left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Go for it

@RunDevelopment
Copy link
Member Author

Yay

@RunDevelopment RunDevelopment merged commit ce0fa22 into PrismJS:master May 7, 2020
@RunDevelopment RunDevelopment deleted the website-improvements branch May 7, 2020 11:40
quentinvernot pushed a commit to TankerHQ/prismjs that referenced this pull request Sep 11, 2020
@RunDevelopment @quentinvernot
Website improvements (PrismJS#2053)
880b77c
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Simran-B Simran-B Simran-B requested changes

@mAAdhaTTah mAAdhaTTah mAAdhaTTah approved these changes

Assignees
No one assigned
Labels
enhancement needs review website
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@RunDevelopment @mAAdhaTTah @Simran-B