Added benchmark suite #2153
Merged
Added benchmark suite #2153
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mAAdhaTTah
reviewed
Jan 5, 2020
You can now specify a URL instead of a file. The benchmark program will automatically download and cache the file.
JaKXz
reviewed
Aug 7, 2021
|
I think this just needs a proper review. @mAAdhaTTah I looked over it again and did some minor refactoring. I think it's good to go but it would be nice if you could review it. |
JaKXz
approved these changes
Aug 8, 2021
mAAdhaTTah
reviewed
Aug 13, 2021
mAAdhaTTah
reviewed
Aug 14, 2021
mAAdhaTTah
reviewed
Aug 14, 2021
mAAdhaTTah
approved these changes
Aug 14, 2021
|
@RunDevelopment I think this can be merged :) |
|
There's still one open comment. cc @mAAdhaTTah |
|
@RunDevelopment sorry, I approved, I don't think that change is necessary. |
|
@mAAdhaTTah Ahh ok. I always read "approved + comments" as "approved if all comments resolved". I'll keep that in mind in the future. |
|
In this case, I thought I had commented and resolved so that's my bad. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds a benchmark suite to Prism.
Since I already explained everything in
benchmark.html, I won't repeat myself but the basic idea is that the whole benchmark configuration is inbenchmark/config.js.Points to discuss
I added support for multiple remote branches because it was easy and useful for testing my implementation but maybe we don't need it?It was pretty easy to implement, so let's just keep it.rn, I only display the mean, margin of error, and sample count. Anything else we need?More information can be added in future PRs if needed.The summary is quite simple, so maybe we could add something?It displays enough information IMO.