feat: handlebars - dot in path names #2172
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
RunDevelopment
requested changes
Jan 10, 2020
There was a problem hiding this comment.
Thank you for your pull request!
Could you please add a test which shows the new : punctuation?
I like the new tests but please use the standard formatting using the --pretty parameter. See Explaining the simplified token stream.
(And don't forget to use tabs :) )
Co-Authored-By: Michael Schmidt <mitchi5000.ms@googlemail.com>
|
@RunDevelopment thank you for fast response! |
RunDevelopment
approved these changes
Jan 10, 2020
|
Thank you for contributing! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.