Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Coy: Minor improvement #2176

Merged
merged 2 commits into from Jun 27, 2020
Merged

Coy: Minor improvement #2176

merged 2 commits into from Jun 27, 2020

Conversation

RunDevelopment
Copy link
Member

Two minor improvements for the Coy theme:

  1. It now consistently uses [class*="language-"].
  2. Removed the :not(pre) > code[class*="language-"]:after selector because code element don't have an after pseudo-element.

@RunDevelopment
Copy link
Member Author

I also noticed that Coy has custom styles for the Show Invisibles plugins which aren't applied.

image

Which may be for the better...

image

Should I fix the theme or remove the rule?

@RunDevelopment RunDevelopment added this to the 1.20.0 milestone Mar 26, 2020
@mAAdhaTTah mAAdhaTTah removed this from the 1.20.0 milestone Apr 6, 2020
mAAdhaTTah
mAAdhaTTah approved these changes Jun 27, 2020
View reviewed changes
Copy link
Member

@mAAdhaTTah mAAdhaTTah left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As for your question, "Right Now" looks better to me too, so let's remove the rule.

@RunDevelopment RunDevelopment merged commit 7109c18 into PrismJS:master Jun 27, 2020
@RunDevelopment RunDevelopment deleted the coy-minor-improvement branch June 27, 2020 19:34
quentinvernot pushed a commit to TankerHQ/prismjs that referenced this pull request Sep 11, 2020
@RunDevelopment @quentinvernot
Coy: Minor improvements (PrismJS#2176)
5f1e7a4
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mAAdhaTTah mAAdhaTTah mAAdhaTTah approved these changes

Assignees
No one assigned
Labels
enhancement needs review themes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@RunDevelopment @mAAdhaTTah