Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Julia: String, character, and other improvements #2363

Merged
merged 6 commits into from May 18, 2020

Conversation

RunDevelopment
Copy link
Member

Julia strings are now greedy. I also reformatted the file.

This fixes #2360.

components/prism-julia.js Outdated Show resolved Hide resolved
@RunDevelopment RunDevelopment changed the title Julia: Greedy strings Julia: String and character improvements May 5, 2020
@RunDevelopment
Copy link
Member Author

I made some other improvements to Julia:

  • Added support for a few missing operators and punctuation. It also fixes this.
  • Added more constants.
  • Improved number pattern.
  • Added regex literals.

@RunDevelopment RunDevelopment changed the title Julia: String and character improvements Julia: String, character, and other improvements May 5, 2020
@cmcaine
Copy link

cmcaine commented May 13, 2020

Does this need any other work?

@cmcaine
Copy link

cmcaine commented May 13, 2020

Looks like prism doesn't support multiline comments, either, btw :)

#= a comment
over
multiple
lines
=#

Technically, multiline comments can nest, like this, but for syntax highlighting I'm sure you can get away without pairing the delimiters if that's hard to support.

#=
       foo
       #=
       bar
       =#
       still a comment
       =#

@RunDevelopment
Copy link
Member Author

Thanks for telling me about multiline comments. I have no idea about Julia, so this really helps.

Does this need any other work?

Not work but review. The other maintainers are very busy, so there's no one to review my PRs. To solve this, I review my own stuff after some time passed (usually 2 weeks). Not ideal but like every open source project we also don't have enough hands.

Don't worry, it's not been forgotten. I'll merge this in a few days.

@cmcaine
Copy link

cmcaine commented May 13, 2020

Great, thanks!

@RunDevelopment RunDevelopment merged commit 81cf234 into PrismJS:master May 18, 2020
@RunDevelopment RunDevelopment deleted the julia-string branch May 18, 2020 23:59
@cmcaine
Copy link

cmcaine commented May 19, 2020

Thanks ❤️

quentinvernot pushed a commit to TankerHQ/prismjs that referenced this pull request Sep 11, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Julia highlighting wonky when multiline string contains backticks
2 participants