Stylus: Put the comment token behind the string token and set the greedy property to true
#2372
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…g detection, and added corresponding unit test.
… in `inside` object, Fix relational tests.
… `greedy` property to `true`
|
I forgot to change the language in MDN, the English site is this. |
RunDevelopment
approved these changes
May 7, 2020
|
I have nothing to add. Really good fix! Thank you for contributing @dev-itsheng! |
quentinvernot
pushed a commit
to TankerHQ/prismjs
that referenced
this pull request
Sep 11, 2020
…ismJS#2372) Comments broke URLs in all non-greedy declarations. Comments are now matched as part of these declarations. This also adds support for comments inside selectors.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
After I solved the bug of comment which break the string and url, I also realized the comment can break the
@namespacerule which namedatrule-declarationtoken in Stylus tokenize. the grammar like this:So at first I try to add
greedy: truein'atrule-declaration'token, but I realized the same problem probably be happened in other tokens, such asvariable-declaration,statement,property-declarationandselector(In fact, I test them and the problems happened).We can certainly add
greedy: truein every token, but I think there is a better solution, as the title says, is putting the token behind them.After that, I remove the
greedy: trueinproperty-declarationtoken.Some extra change:
To match the comment in
selectortoken, I addedcommentproperty inproperty.insideobject.To match the following comment, the
greedy: trueincommentshould be set:Finally, about test:
To improve the changed code correctness, the tests of all scenes (all scenes which I can think about, there could be something that I ignore) are added.