Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Protobuf: Added support for RPC #2414

Merged
merged 2 commits into from Jun 7, 2020

Conversation

RunDevelopment
Copy link
Member

This adds support for the Protobuf RPC syntax.

I also made some minor improvements such as a lookahead for keywords to prevent false positives with field names and some pattern improvements.

Copy link
Member

@mAAdhaTTah mAAdhaTTah left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One filename change, but gtg!

@RunDevelopment RunDevelopment merged commit 939a17c into PrismJS:master Jun 7, 2020
@RunDevelopment RunDevelopment deleted the protobuf-rpc branch June 7, 2020 16:52
@RunDevelopment
Copy link
Member Author

Thanks for the reviews @mAAdhaTTah!

@mAAdhaTTah
Copy link
Member

@RunDevelopment np. Going to take a closer look through the templating one later.

quentinvernot pushed a commit to TankerHQ/prismjs that referenced this pull request Sep 11, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants