Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Disable highlighting of strings inside comments in a Dockerfile #2428

Merged
merged 1 commit into from Jun 21, 2020
Merged

Disable highlighting of strings inside comments in a Dockerfile #2428

merged 1 commit into from Jun 21, 2020

Conversation

edukisto
Copy link
Contributor

Resolves #2427.

@RunDevelopment RunDevelopment merged commit 37273a6 into PrismJS:master Jun 21, 2020
@RunDevelopment
Copy link
Member

Thank you for contributing @edukisto!

@edukisto edukisto deleted the disable-strings-inside-comments-in-dockerfiles branch June 21, 2020 08:52
@edukisto
Copy link
Contributor Author

You’re welcome, @RunDevelopment!

quentinvernot pushed a commit to TankerHQ/prismjs that referenced this pull request Sep 11, 2020
@edukisto @quentinvernot
Dockerfile: Fixed strings inside comments (PrismJS#2428)
edb29d5 
Strings inside comments broke comments. Comments are now greedy, so this can't happen anymore.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@RunDevelopment RunDevelopment RunDevelopment approved these changes

Assignees
No one assigned
Labels
enhancement language-definitions
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Strings break out of comments in a Dockerfile
2 participants
@edukisto @RunDevelopment