Macro string functions #2463
Merged
Macro string functions #2463
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…o be considered a string. This new construction handles identifying the content within a string function as a string.
…/prism into macro_string_functions
Co-authored-by: Michael Schmidt <mitchi5000.ms@googlemail.com>
… strings. They do, however, need to recognize nested macro functions and escaped characters
RunDevelopment
requested changes
Jul 6, 2020
RunDevelopment
approved these changes
Jul 6, 2020
|
Thank you for contributing! |
quentinvernot
pushed a commit
to TankerHQ/prismjs
that referenced
this pull request
Sep 11, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Don't actually need to mark the contents of these macro string functions as strings. Do need to ensure that unmatched quotes within them are not erroneously identified as the start and end of strings. Also improved macro variable identification.