Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add aliases for Kotlin #2474

Merged
merged 2 commits into from Jul 13, 2020
Merged

Add aliases for Kotlin #2474

merged 2 commits into from Jul 13, 2020

Conversation

osipxd
Copy link
Contributor

@osipxd osipxd commented Jul 13, 2020

Added file extensions kt and kts as aliases for Kotlin.

RunDevelopment
RunDevelopment approved these changes Jul 13, 2020
View reviewed changes
Copy link
Member

@RunDevelopment RunDevelopment left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for making this @osipxd!

To make the tests pass, you also have to change prism-kotlin.js. (For more information, see the "adding aliases" section here.)

@osipxd
Copy link
Contributor Author

osipxd commented Jul 13, 2020 •
edited

Thank you for making this @osipxd!

To make the tests pass, you also have to change prism-kotlin.js. (For more information, see the "adding aliases" section here.)

Ah, missed it. Should be fixed now.

@RunDevelopment RunDevelopment merged commit 67f97e2 into PrismJS:master Jul 13, 2020
@RunDevelopment
Copy link
Member

Thank you for contributing!

@osipxd osipxd deleted the feature/kotlin_aliases branch July 21, 2020 17:44
quentinvernot pushed a commit to TankerHQ/prismjs that referenced this pull request Sep 11, 2020
@osipxd @quentinvernot
Kotlin: Added kt and kts aliases (PrismJS#2474)
e320529
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@RunDevelopment RunDevelopment RunDevelopment approved these changes

Assignees
No one assigned
Labels
enhancement language-definitions needs changes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@osipxd @RunDevelopment