Shell session: Commands prefixed with a path are now detected #2686
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mAAdhaTTah
reviewed
Jan 1, 2021
| ["builtin", "exit"] | ||
| ]] | ||
| ]] | ||
| ] |
There was a problem hiding this comment.
I used the npm run test:languages -- --accept command to insert the token stream. With or without final new line, I don't mind, but if it's something that bothers you, then I'll change the implementation.
There was a problem hiding this comment.
lol it doesn't really bother me but I've noticed you making that change elsewhere so I figured we wanted consistency.
There was a problem hiding this comment.
Ahh kk. I only make that change everywhere because I configured my IDE that way.
If we really want that consistency, then I'll just reformat all test files. Only takes a second but will probably change ~500 files. Maybe it's not that necessary.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes #2685.