Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: bug #2614 class-name is now matched before keyword #2731

Conversation

TomPavelec
Copy link
Contributor

Closes #2614

…en when code starts with "class" keyword then next class name is matched correctly
@github-actions
Copy link

github-actions bot commented Jan 20, 2021

JS File Size Changes (gzipped)

A total of 1 files have changed, with a combined diff of +21 B (+1.1%).

file master pull size diff % diff
components/prism-php.min.js 1.84 KB 1.86 KB +21 B +1.1%

Generated by 🚫 dangerJS against 0ae183e

Copy link
Member

@RunDevelopment RunDevelopment left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for the PR @TomPavelec!

A few nits. Also, could you please add a test for the code snippet in #2614 to show that the bug has been fixed?

components/prism-php.js Outdated Show resolved Hide resolved
components/prism-php.js Outdated Show resolved Hide resolved
components/prism-php.js Outdated Show resolved Hide resolved
@TomPavelec
Copy link
Contributor Author

Thank you for quick response @RunDevelopment.

@RunDevelopment RunDevelopment merged commit 04ef309 into PrismJS:master Jan 20, 2021
@RunDevelopment
Copy link
Member

Thank you for contributing @TomPavelec!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[PHP] When code begins with class, class-name after it is not matched.
2 participants