Dangerfile: Fixed how changed files are determined #2757
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I'm sure some of you noticed that the bundle size messages our bot procured sometimes contained files that were not changed in the current PR. This PR fixed that issue.
The cause of this problem was the
git diffcommand.git diffsimply returns a list of files that are different between two commits/branches. However, this is now what we want. The problem is that this did not account for commits added to master after the PR branch was branched off master. The solution is to find the proper merge base commit before diffing.(I also moved up the function definition so it's closer to other git functions.)