Copy to clipboard: Removed ClipboardJS dependency #2784
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This removes Copy to clipboard's dependency on ClipboardJS.
ClipboardJS has been replaced with a few functions that behave similarly. The actual copying is implemented by the Async + fallback combo here. This alone should give us very good browser compatibility (works in IE11).
Older FF versions do not support copying text to the clipboard at all. For these browsers, we use the same trick as ClipboardJS: we just select the text to copy and ask the user to press Ctrl+C. It's implemented slightly differently, however. ClipboardJS creates a temporary invisible element and selects the text of that but we can just select the text of the
<code>
element we want to copy (makes everything a lot easier).This may scroll the code block but I didn't give this much consideration since it will only affect a very small portion of our users.
Prism now has 0 required (runtime) dependencies on other libraries.
This resolves #2783
This resolves #2565
This resolves #2286