Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Xojo language was completed. #2805

Merged
merged 5 commits into from Mar 16, 2021
Merged

Xojo language was completed. #2805

merged 5 commits into from Mar 16, 2021

Conversation

XojoGermany
Copy link
Contributor

Xojo language was completed (missing keywords etc.).

Xojo language was completed (missing keywords etc.).
@github-actions
Copy link

github-actions bot commented Mar 16, 2021

JS File Size Changes (gzipped)

A total of 1 files have changed, with a combined diff of +188 B (+34.6%).

file master pull size diff % diff
components/prism-xojo.min.js 544 B 732 B +188 B +34.6%

Generated by 🚫 dangerJS against db385aa

Added missing "Variant" Keyword (data type).
@RunDevelopment
Copy link
Member

Please also add the new keywords to Xojo's keyword test. You can find more information about the test suite here.

@XojoGermany
Copy link
Contributor Author

Please also add the new keywords to Xojo's keyword test. You can find more information about the test suite here.

Done ;)

@RunDevelopment
Copy link
Member

Tests fail because the expected token stream is incorrect. The fasted way to solve this is to delete the incorrect expected token stream (just delete all the JSON) and then run npm run test:languages -- --accept.

@XojoGermany
Copy link
Contributor Author

Tests fail because the expected token stream is incorrect. The fasted way to solve this is to delete the incorrect expected token stream (just delete all the JSON) and then run npm run test:languages -- --accept.

I am sorry, I am not familiar with these tests and unfortunately do not know how exactly to proceed. I only wanted to complete the Xojo Language reference. Where do I have to run npm run test:languages -- --accept.

@RunDevelopment
Copy link
Member

Don't worry about it. Do the following steps:

  1. Delete the expected token stream and save the file.
  2. Run npm run test:languages -- --accept in your console/terminal (cd to the Prism directory before).
  3. Commit all changes.

@XojoGermany
Copy link
Contributor Author

Don't worry about it. Do the following steps:

  1. Delete the expected token stream and save the file.
  2. Run npm run test:languages -- --accept in your console/terminal (cd to the Prism directory before).
  3. Commit all changes.

I just did that and unfortunately I get this error message. I'm sorry, I really have no experience with this at all :-(
Xojo

@RunDevelopment
Copy link
Member

Ah, yes. You have to install Prism's dependencies beforehand. Run npm ci before doing the steps that I gave you.

@XojoGermany
Copy link
Contributor Author

Thanks for guiding me this far ;) Greetings to Leipzig

@RunDevelopment RunDevelopment merged commit 459365e into PrismJS:master Mar 16, 2021
@RunDevelopment
Copy link
Member

Thank you for contributing!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants