add advanced graphql changes separate from test changes #2939
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- atom-input for Input type objects for mutations and type definitions - variable-input to go along with atom-input - built in scalars - definition-mutation and definition-query - property-query and property-mutation - base property token for all other tokens because all text in graphql is significant. Co-Authored-By: Michael Schmidt <mitchi5000.ms@googlemail.com>
JaKXz
force-pushed
the
feat/advanced-graphql-2
branch
from
4366ca5
to
3a89305
Compare
|
Sorry for the delay @JaKXz!
I'm sorry to hear that. Coincidentally, I just opened an issue for a new hook (#2949) that would solve your problem. But this hook will likely only be added in v2.0. |
RunDevelopment
approved these changes
Jun 13, 2021
|
I just merged a few PRs that changed a bunch of files. Let me quickly resolve the merge conflict. |
|
@JaKXz Also, you should request your vendor to support the |
|
No worries, thanks for merging! :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@RunDevelopment ironically after all the discussion about "integration" tests from #2927, I realized the library I'm using that vendors Prism only uses the
.tokenizemethod so I'm not able to use plugins anyway 馃槀 馃槶Here's the PR for just the advanced graphql changes without any major modifications to the test suite :)
Closes #2927