Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

JS Templates: Added SQL templates #2945

Merged
merged 1 commit into from Jun 14, 2021

Conversation

RunDevelopment
Copy link
Member

This resolves the issue brought up by this comment.

@github-actions
Copy link

JS File Size Changes (gzipped)

A total of 1 files have changed, with a combined diff of +5 B (+0.4%).

file master pull size diff % diff
components/prism-js-templates.min.js 1.17 KB 1.17 KB +5 B +0.4%

Generated by 🚫 dangerJS against a8f1fa6

Copy link
Collaborator

@JaKXz JaKXz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM :)

@RunDevelopment RunDevelopment merged commit abab910 into PrismJS:master Jun 14, 2021
@RunDevelopment RunDevelopment deleted the js-templates-sql branch June 14, 2021 10:55
@karlhorky
Copy link
Contributor

Thanks! Will this be a new minor (1.24.0)?

@RunDevelopment
Copy link
Member Author

Yes.

@karlhorky
Copy link
Contributor

Great, looks like it's working with prism@1.24.0 🎉

const users = await sql`
  SELECT * FROM users WHERE id = ${id}
`;

Screen Shot 2021-07-04 at 17 57 21

In order to achieve this, I had to load the following languages (in this order):

  1. SQL
  2. JS Templates
  3. JavaScript

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants