Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for @propertyWrapper, @MainActor, @globalActor #3009

Merged
merged 7 commits into from Jul 26, 2021
Merged

Add support for @propertyWrapper, @MainActor, @globalActor #3009

merged 7 commits into from Jul 26, 2021

Conversation

AvdLee
Copy link
Contributor

@AvdLee AvdLee commented Jul 24, 2021

New types that didn't exist in Prism yet, but we need them! 馃帀

@github-actions
Copy link

github-actions bot commented Jul 24, 2021

JS File Size Changes (gzipped)

A total of 1 files have changed, with a combined diff of +20 B (+1.9%).

file master pull size diff % diff
components/prism-swift.min.js 1.04 KB 1.06 KB +20 B +1.9%

Generated by 馃毇 dangerJS against 09bf331

Copy link
Member

@RunDevelopment RunDevelopment left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One minor nit. Apart from that it's gtg. Thank you @AvdLee!

components/prism-swift.js Outdated Show resolved Hide resolved
@RunDevelopment
Copy link
Member

Also, please use backticks around @propertyWrapper (and others) in commit messages, comments, and titles. Otherwise, GitHub will ping these people. Let's try to not annoy them :)

Co-authored-by: Michael Schmidt <mitchi5000.ms@googlemail.com>
@AvdLee
Copy link
Contributor Author

AvdLee commented Jul 26, 2021

Also, please use backticks around @propertyWrapper (and others) in commit messages, comments, and titles. Otherwise, GitHub will ping these people. Let's try to not annoy them :)

Oh, oops! didn't think about that!

@RunDevelopment
Copy link
Member

The build still fails. Could you please rebuild Prism?

@AvdLee
Copy link
Contributor Author

AvdLee commented Jul 26, 2021

The build still fails. Could you please rebuild Prism?

I've never done that before, my previous PR succeeded as well w/o rebuilding Prism 馃
Is there any guidance for this? I'm not really experienced in deploying such packages

@RunDevelopment
Copy link
Member

Just run npm ci && npm run build and commit the changes.

@AvdLee
Copy link
Contributor Author

AvdLee commented Jul 26, 2021

Thanks, that was actually easy. Pushed the changes, let's see if CI is happy now!

@RunDevelopment RunDevelopment merged commit ce5e0f0 into PrismJS:master Jul 26, 2021
@RunDevelopment
Copy link
Member

Thank you for contributing @AvdLee!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants