feat: add Bicep support #3027
Merged
feat: add Bicep support #3027
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
RunDevelopment
requested changes
Aug 5, 2021
There was a problem hiding this comment.
Thank you for making this PR @johnnyreilly!
I have a few questions and suggestions. Tests are failing because languages in components.json aren't sorted alphabetically (you need to swap bicep and birb).
|
Tests should now be fixed I hope |
you're totally right Co-authored-by: Michael Schmidt <mitchi5000.ms@googlemail.com>
Co-authored-by: Michael Schmidt <mitchi5000.ms@googlemail.com>
RunDevelopment
approved these changes
Aug 5, 2021
|
Thank you for contributing @johnnyreilly! |
|
Thanks for the help with the regex! |
5 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds basic support for the Bicep language.
#2816
Snapshots generated with
npm run test:languages -- --language=bicep --update