Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added support for GN #3062

Merged
merged 2 commits into from Sep 1, 2021
Merged

Added support for GN #3062

merged 2 commits into from Sep 1, 2021

Conversation

RunDevelopment
Copy link
Member

@RunDevelopment RunDevelopment commented Sep 1, 2021 •
edited

This resolves #3061.

image

@github-actions
Copy link

github-actions bot commented Sep 1, 2021 •
edited

JS File Size Changes (gzipped)

A total of 3 files have changed, with a combined diff of +558 B (+12.1%).

file master pull size diff % diff
components/prism-gn.min.js 0 Bytes 544 B +544 B +100.0%
plugins/autoloader/prism-autoloader.min.js 2.23 KB 2.24 KB +6 B +0.3%
plugins/show-language/prism-show-language.min.js 2.36 KB 2.37 KB +8 B +0.3%

Generated by 🚫 dangerJS against cd3e489

thunder-coding
thunder-coding suggested changes Sep 1, 2021
View reviewed changes
Copy link

@thunder-coding thunder-coding left a comment •
edited

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

https://github.com/thunder-coding/gn/blob/69ec4fca1fa69ddadae13f9e6b7507efa0675263/misc/vim/syntax/gn.vim#L19-L25

There are some predefined variables too in GN which I feel should be highlighted differently than normal variables

@RunDevelopment
Copy link
Member Author

Done. I updated the screenshot so you can see the changes.

@RunDevelopment RunDevelopment merged commit 4f97b82 into PrismJS:master Sep 1, 2021
@RunDevelopment RunDevelopment deleted the issue3061 branch September 1, 2021 16:08
@sync-by-unito sync-by-unito bot mentioned this pull request Sep 17, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@thunder-coding thunder-coding thunder-coding approved these changes

Assignees
No one assigned
Labels
language-definitions needs review new language
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Language Request: GN
2 participants
@RunDevelopment @thunder-coding