Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use tabs in package(-lock).json #3098

Merged
merged 1 commit into from Sep 27, 2021
Merged

Use tabs in package(-lock).json #3098

merged 1 commit into from Sep 27, 2021

Conversation

valtlai
Copy link
Contributor

@valtlai valtlai commented Sep 27, 2021

This is more consistent with the most of the code base, and npm will preserve the indentation style.

@github-actions
Copy link

No JS Changes

Generated by 🚫 dangerJS against d50d3ef

@RunDevelopment
Copy link
Member

Thank you for the PR @valtlai!

Both of these files are generated and managed by npm. We can't choose the indentation because every npm i <something> will change it back spaces. So it's impractical to maintain tabs.

For this reason, I will reject this PR.

@valtlai
Copy link
Contributor Author

valtlai commented Sep 27, 2021

That’s not true: npm does maintain the indentation style, i.e. running npm i <something>, for example, won’t change tabs back to spaces. I tested it with both npm v6 and v7.

@RunDevelopment
Copy link
Member

Oh, I found an old issue where people were angry that it didn't. They must have changed it since then.

@valtlai
Copy link
Contributor Author

valtlai commented Sep 27, 2021

Yeah, I’ve probably used npm too little time since I didn’t know this hasn’t always worked like today. 😄

@RunDevelopment RunDevelopment merged commit 8daebb4 into PrismJS:master Sep 27, 2021
@RunDevelopment
Copy link
Member

Thank you for contributing @valtlai!

@valtlai valtlai deleted the tabs branch October 5, 2021 07:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants