Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Elm: Recognise unicode escapes as valid Char #3105

Merged
merged 5 commits into from Oct 3, 2021
Merged

Elm: Recognise unicode escapes as valid Char #3105

merged 5 commits into from Oct 3, 2021

Conversation

hoonweiting
Copy link
Contributor

Elm recognises unicode escapes from '\u{0000}' to '\u{10FFFF}' as valid Char. Not sure if the regex I modified is the best way to do it though!

@github-actions
Copy link

github-actions bot commented Oct 3, 2021 •
edited

JS File Size Changes (gzipped)

A total of 1 files have changed, with a combined diff of +5 B (+0.8%).

file master pull size diff % diff
components/prism-elm.min.js 596 B 601 B +5 B +0.8%

Generated by 🚫 dangerJS against fba86d0

RunDevelopment
RunDevelopment requested changes Oct 3, 2021
View reviewed changes
Copy link
Member

@RunDevelopment RunDevelopment left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR @hoonweiting!

Only one nit!

components/prism-elm.js Outdated Show resolved Hide resolved
hoonweiting and others added 2 commits October 4, 2021 02:01
@hoonweiting @RunDevelopment
Account for lowercase hexadecimal and ignore length
583d038 
Co-authored-by: Michael Schmidt <msrd0000@gmail.com>
@hoonweiting
Rebuild Prism
fba86d0
@RunDevelopment RunDevelopment merged commit 736c581 into PrismJS:master Oct 3, 2021
@RunDevelopment
Copy link
Member

Thank you for contributing @hoonweiting!

@hoonweiting hoonweiting deleted the elm-char branch October 3, 2021 18:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@RunDevelopment RunDevelopment RunDevelopment approved these changes

Assignees
No one assigned
Labels
enhancement language-definitions needs changes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@hoonweiting @RunDevelopment